-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch macOS and Linux default toolchain to .NET 5. #19026
Conversation
a249692
to
3332edf
Compare
The updated install document can be viewed in a readable form at https://github.com/pchote/OpenRA/blob/net5-makefile/INSTALL.md |
We should also merge #19006 first to avoid unnecessary rebase pain wrt the prep branch. |
Updated to include the configure-system-libraries.sh fix from #19057. The build refuses to run with |
On mono or dotnet, both? |
e876166
to
19ddc55
Compare
Only on dotnet, only for libsdl2.dylib, and only on macOS. It works fine on Linux (provided the system has a recent enough version of SDL2 installed), and works fine on macOS for the other dylibs. When I tried compiling my own version of SDL2 locally, the game freezes during startup under both mono and dotnet. This was working fine when I first opened the PR, so I don't understand what has broken... Since |
Rebased now that #19006 has been merged. |
Updated. |
This PR should cover all the remaining details to switch our default toolchain to .NET 5, keeping compatibility with mono for those who want it on macOS and Linux.