Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add death types support to the Lua Kill() API. #19038

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

pchote
Copy link
Member

@pchote pchote commented Jan 10, 2021

Fixes #18169.

Adding this to the milestone because @Smittytron has another ant mission ready to PR that depends on this (which i'd like to get into the playtest too), and it sounds like we can also use this to fix a polish bug in Sarin Gas 2 (if someone can tell me the changes i'll add them here).

Testcase: add the following snippet to the bottom of SendInsertionHelicopter in mods/ra/maps/allies-01/allies01.lua and uncomment each case to test:

Trigger.AfterDelay(DateTime.Seconds(4), function()
	tanya.Kill()
	--tanya.Kill("FireDeath")
	--tanya.Kill({"FireDeath", "Incendiary"})
end)

Mailaender
Mailaender previously approved these changes Jan 10, 2021
Smittytron
Smittytron previously approved these changes Jan 10, 2021
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

and it sounds like we can also use this to fix a polish bug in Sarin Gas 2 (if someone can tell me the changes i'll add them here).

That'll be "ExplosionDeath" on line 116.

@pchote pchote dismissed stale reviews from Smittytron and Mailaender via c655877 January 10, 2021 22:40
@pchote
Copy link
Member Author

pchote commented Jan 10, 2021

Updated Sarin Gas 2 and also Top o' the World. These are the only two missions I can see that use .Kill() on infantry.

@abcdefg30 abcdefg30 merged commit 2eee911 into OpenRA:bleed Jan 11, 2021
@abcdefg30
Copy link
Member

@pchote pchote deleted the lua-deathtypes branch April 8, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lua API: Kill should allow definitions for death animation and death sound notification
4 participants