Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InitialActor to Carryall. #19068

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

MustaphaTR
Copy link
Member

This is used in RV for some AI duplicate units to make AI use carryalls.

Testcase makes Orca Carrier in TS spawn with a Titan on it.

@MustaphaTR
Copy link
Member Author

Updated.

phrohdoh
phrohdoh previously approved these changes Feb 5, 2021
Copy link
Member

@phrohdoh phrohdoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM - untested in-game

Smittytron
Smittytron previously approved these changes Feb 10, 2021
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@pchote
Copy link
Member

pchote commented Feb 13, 2021

Can you please remove the testcase?

@MustaphaTR
Copy link
Member Author

Removed the testcase.

@pchote pchote merged commit df94f0e into OpenRA:bleed Feb 14, 2021
@MustaphaTR MustaphaTR deleted the carryall-initial-actor branch February 14, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants