Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self-contained packaging. #19225

Merged
merged 1 commit into from Mar 13, 2021
Merged

Fix self-contained packaging. #19225

merged 1 commit into from Mar 13, 2021

Conversation

pchote
Copy link
Member

@pchote pchote commented Mar 9, 2021

The .NET docs noted that the --self-contained parameter would

Default is true if a runtime identifier is specified and the project is an executable project (not a library project).

I initially interpreted this as meaning it would default to true for all the projects in the sln, because it would be crazy if some projects were treated as self contained and others weren't when all are being published together. It turns out that .NET is crazy, and that the csproj changes in #18995 introduced new breaking errors related to this (thanks to @IceReaper for discovering the issue).

Setting --self-contained explicitly fixes this, and also appears to solve the trimming problems from the original PR, so i'm dropping those workarounds too.

Test release: https://github.com/pchote/OpenRA/releases/tag/devtest-20210309

@IceReaper
Copy link
Contributor

I can confirm that the packaging works. However...
Windows: When running the installer, it basicaly spamt error at the end of the installation process for 1-2 minutes:
image

AppImage running dedicated server: It directly crashes on start with

File name: 'System.Runtime, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

@pchote
Copy link
Member Author

pchote commented Mar 10, 2021

That is caused by OpenRA/OpenRAModSDK#171 (comment), so nothing to worry about here.

@Mailaender Mailaender merged commit b622afd into OpenRA:bleed Mar 13, 2021
@Mailaender
Copy link
Member

Works fine on Linux. I don't know what to changelog here though.

@pchote pchote deleted the fix-packaging branch April 8, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants