Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET docs noted that the
--self-contained
parameter wouldI initially interpreted this as meaning it would default to true for all the projects in the sln, because it would be crazy if some projects were treated as self contained and others weren't when all are being published together. It turns out that .NET is crazy, and that the csproj changes in #18995 introduced new breaking errors related to this (thanks to @IceReaper for discovering the issue).
Setting
--self-contained
explicitly fixes this, and also appears to solve the trimming problems from the original PR, so i'm dropping those workarounds too.Test release: https://github.com/pchote/OpenRA/releases/tag/devtest-20210309