Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition support to ActorLostNotification. #19246

Merged
merged 1 commit into from Mar 20, 2021
Merged

Add condition support to ActorLostNotification. #19246

merged 1 commit into from Mar 20, 2021

Conversation

pchote
Copy link
Member

@pchote pchote commented Mar 14, 2021

Fixes #19244.

Testcase: Change the ActorLostNotification on ^NeutralPlane to

	ActorLostNotification@airborne:
		RequiresCondition: airborne
		Notification: AirUnitLost
	ActorLostNotification:
		RequiresCondition: !airborne
		Notification: UnitLost

and notice that airborne planes give "Airborne unit lost" while planes on the airfield give "Unit lost".

Smittytron
Smittytron approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@reaperrr reaperrr merged commit e63b9b4 into OpenRA:bleed Mar 20, 2021
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/5d9bfa864673fd0470ebacb9fafa396bc2349325...26a3e4a6a14271bd5fb8285d2b98688d3c093766

@pchote pchote deleted the conditional-actorlost branch April 8, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@Smittytron Smittytron Smittytron approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RequiredCondition for ActorLostNotification
3 participants
@pchote @reaperrr @Smittytron