Move projects properties to Directory.Build.props

[Shkarlatov]

Split *.csproj to local and shared properties.
It makes it easier to change global project properties and add a new conditions.

Documentation Customize your build

[penev92]

Hey, thank you for your first contribution, it seems intriguing at a glance!

[pchote]

This looks really useful. The Windows .NET 5 build CI build is now consistently failing (i've rerun the workflow a couple of times to check), but i'm not sure if this is related to these changes or is some unrelated issue with the GH environment.

[Shkarlatov]

This looks really useful. The Windows .NET 5 build CI build is now consistently failing (i've rerun the workflow a couple of times to check), but i'm not sure if this is related to these changes or is some unrelated issue with the GH environment.

May be add dotnet restore after dotnet nuget locals all --clear in

OpenRA/.github/workflows/ci.yaml

Lines 65 to 70 in fe12995

	run: |
	# Work around runtime failures on the GH Actions runner
	dotnet nuget locals all --clear
	.\make.ps1 check
	dotnet build OpenRA.Test\OpenRA.Test.csproj -c Debug --nologo -p:TargetPlatform=win-x64
	dotnet test bin\OpenRA.Test.dll --test-adapter-path:.

It github-env issue

[pchote]

Can you please try adding that in this PR?

[pchote]

Here are my notes from comparing removals and additions. Most of these are just information, but there are a few change requests in there.

Once the fixups are applied I will tag a devtest build so we can verify that packaged releases have not regressed.

[pchote]

Can you please now squash the fixup commits? https://github.com/OpenRA/OpenRA/wiki/Contributing#updating-a-pull-request

[pchote]

I pushed a test build to https://github.com/pchote/OpenRA/releases/tag/devtest-20210408

The macOS, AppImage, and Windows 32bit builds appear to work as expected. The Windows 64bit build doesn't launch and doesn't even appear to crash, no output at all. Can anyone else repro?

[Shkarlatov]

@pchote I tested builds. I cant build dotnet build -r win-x86 (win-x64 also). Without RID build is success. It is dotnet error dotnet/sdk#14281
Workaround: dotnet build -r win-x64 -p:ImportByWildcardBeforeSolution=false

[pchote]

That's odd. The x64 .NET 5 builds were working fine every time we've tested them before now - is something specific in this PR triggering the bug?

[Shkarlatov]

@pchote How build x64? I download OpenRA-release-20210321.zip (src) , run dotnet build -r win-x86.

error NETSDK1134: Building a solution with a specific RuntimeIdentifier is not supported. If you would like to publish for a single RID, specifiy the RID at the individual project level instead.

C:\Program Files\dotnet\sdk\5.0.201\Current\SolutionFile\ImportAfter\Microsoft.NET.Sdk.Solution.targets(27,5): error NETSDK1134: сборка решения с заданным идентификатором RuntimeIdentifier не поддерживается. Если вы хотите выполнить публикацию для одного RID, укажите RID на уровне отдельного проекта. [D:\Downloads\OpenRA-release-20210321\OpenRA.sln]

Not sure if PR not contain problem.

[Shkarlatov]

I found how build and packaging. msbuild -verbosity:m -nologo -t:Build -restore -p:Configuration=Release -p:TargetPlatform=win-x64 build success

[Shkarlatov]

devenv /DebugExe "D:\Downloads\OpenRA-devtest-20210408-x64-winportable\Dune2000.exe"

Exception thrown at 0x00007FFEFEA6D759 (KernelBase.dll) in Dune2000.exe: 0x04242420 (parameters: 0x0000000031415927, 0x00007FFEBDDD0000, 0x0000006B2A97E3B0).
Exception thrown at 0x00007FFEFEA6D759 in Dune2000.exe: Microsoft C++ exception: HRException at memory location 0x0000006B2A97E778.
Exception thrown at 0x00007FFEFEA6D759 in Dune2000.exe: Microsoft C++ exception: [rethrow] at memory location 0x0000000000000000.
Exception thrown at 0x00007FFEFEA6D759 in Dune2000.exe: Microsoft C++ exception: HRException at memory location 0x0000006B2A97E778.
Exception thrown at 0x00007FFEFEA6D759 in Dune2000.exe: Microsoft C++ exception: EEFileLoadException at memory location 0x0000006B2A97A1C8.
Exception thrown at 0x00007FFEFEA6D759 in Dune2000.exe: Microsoft C++ exception: [rethrow] at memory location 0x0000000000000000.
Exception thrown at 0x00007FFEFEA6D759 in Dune2000.exe: Microsoft C++ exception: EEFileLoadException at memory location 0x0000006B2A97A1C8.
Failed to create CoreCLR, HRESULT: 0x80004005Failed to create CoreCLR, HRESULT: 0x80004005

[pchote]

LGTM and tested:

• All release packages now work as expected (https://github.com/pchote/OpenRA/releases/tag/devtest-20210411)
• Compiling using the Makefile works with both .NET5 and Mono
• Building and running through Rider still works as expected

For some reason debugging through Rider is not working on my system (hangs during startup), but this is also a problem on bleed so does not appear to be related to this PR.

[pchote]

It would be good if we could get this merged sooner rather than later for the CI fix.

[penev92]

LGTM, just needs a few things to be addressed.

• Also I notice UseVSHostingProcess properties have disappeared from 3 projects, but something tells me that's for the better?
• And AutoGenerateBindingRedirects properties have also disappeared?

[pchote]

@penev92 see #19325 (comment) and #19325 (comment)

[penev92]

Thanks.

[pchote]

I have force pushed fixups for @penev92's requests so we can merge this ASAP

[reaperrr]

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/f3ab714041b9c5cfd1a767aed570ad1893f9367a...8c65199c897b61278abdc902ba07dbb250d27648