Put game on diet #19360
Put game on diet #19360
Conversation
|
|
||
| namespace OpenRA | ||
| { | ||
| public class ExternalModSwitcher |
There was a problem hiding this comment.
Can this be merged into the ExternalMods class and then called as Game.ExternalMods.Switch()?
There was a problem hiding this comment.
Thought about that too, was not sure about that so started with the dedicated class.
There was a problem hiding this comment.
Problem is that we need to supply launchWrapper , we could supply it through the constructor, but we use ExternalMods in other places where we dont have that and also not using it.
| @@ -0,0 +1,56 @@ | |||
| #region Copyright & License Information | |||
| /* | |||
| * Copyright 2007-2020 The OpenRA Developers (see AUTHORS) | |||
| { | ||
| public class ScreenshotManager | ||
| { | ||
| public static void TakeScreenshot() |
There was a problem hiding this comment.
This would probably make sense merged into Renderer?
There was a problem hiding this comment.
Another idea is to move most of the logic from the screenshot logic code out from the renderer class and only let it return the data.
|
|
||
| namespace OpenRA | ||
| { | ||
| public class TextManager |
There was a problem hiding this comment.
Is there any sensible owner (e.g. ModData) that would allow this to not be static?
| @@ -0,0 +1,36 @@ | |||
| #region Copyright & License Information | |||
| /* | |||
| * Copyright 2007-2020 The OpenRA Developers (see AUTHORS) | |||
|
Do we want to keep this PR open? It seems we've already done many of the proposed changes and the name of the PR is fairly missleading |
Moving some of the code from the Game class to dedicated classes.