Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Text handling to its own class #19436

Merged
merged 1 commit into from Jun 4, 2021
Merged

Move Text handling to its own class #19436

merged 1 commit into from Jun 4, 2021

Conversation

teinarss
Copy link
Contributor

@teinarss teinarss commented Jun 3, 2021

Split from #19360

abcdefg30
abcdefg30 previously approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the name of the class, but code changes lgtm.

OpenRA.Game/TextManager.cs Outdated Show resolved Hide resolved
@teinarss
Copy link
Contributor Author

teinarss commented Jun 4, 2021

Updated.

@reaperrr reaperrr merged commit 82115c6 into OpenRA:bleed Jun 4, 2021
@reaperrr
Copy link
Contributor

reaperrr commented Jun 4, 2021

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/563c1901ab03b97a4e43df901470bbe82c54072c...ec1f5939280cc3b07043f5433c08d0ed32858a12

@dragunoff dragunoff mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragunoff dragunoff dragunoff left review comments

@reaperrr reaperrr reaperrr approved these changes

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teinarss @reaperrr @dragunoff @abcdefg30