Add engine support for RGBA remap hue/saturation colour shifts. #19367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
force-pushed
the
playercolor-colorshift
branch
from
110dcac
to
a83fe03
Compare
chrisforbes
reviewed
Apr 23, 2021
OpenRA.Game/Primitives/Color.cs
Outdated
| @@ -155,46 +193,6 @@ public float GetBrightness() | |||
| return (max + min) / 510f; | |||
| } | |||
|
|
|||
| public float GetSaturation() | |||
chrisforbes
previously approved these changes
Apr 23, 2021
pchote
commented
May 13, 2021
pchote
force-pushed
the
playercolor-colorshift
branch
2 times, most recently
from
0758381
to
6abde6e
Compare
|
needs a rebase. |
This was previously decreased to support legacy GPUs that only supported 8 texture image units and we need to reserve one of these for the palette texture. OpenGL 3.X mandates a minimum of 16 (and most most GL2 cards also supported it) so we can now safely increase this limit.
This avoids reallocating buffers each time the player changes zoom level.
pchote
force-pushed
the
playercolor-colorshift
branch
from
6abde6e
to
dd91448
Compare
|
Rebased and removed the testcase. That is pushed as 18532af if anyone else still wanted to try it. |
reaperrr
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the engine backend for chroma-keyed player colours on 32bit sprites.
Depends on #19335 (only the last 4 commits are new).
#3692 basically forces us to treat these as add-ons to existing indexed palettes. This fits well with our first major usecase (remastered asset support), but isn't great for mods that might want to exclusively use 32 bit sprites. The actual engine plumbing won't change much, but this does impact the way we set up the traits.
For this reason i'm limiting this PR to the engine plumbing, and leaving the actual traits to downstream mods until #3692 has been finished. This strikes a balance where advanced modders can start to use the feature and provide feedback/bugs but not lock us into supporting a set of traits that we know will need to be replaced.
The testcase commit adds @mabulsoud's chronosphere to the asset browser. Open the asset browser, search for pdox.png, and notice that it responds to the color picker.