-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace F extension with string interpolation #19372
Conversation
There are a bunch of places (e.g. the first several exception changes in the files view) where this is inserting arbitrary newlines that IMO hurt readability more than they help. Can we please unstage those? |
Updated. |
The only places where we are using |
How would this work with localization? 🤔 |
The translation library has its own string replacement system, so won't interact with this at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think its really awful when string interpolations include arbitrarily complex expressions, but I don't think it is productive to get hung up over that here. The majority of cases in this PR are simple variables and are a clear improvement, and the ugly cases can be cleaned up the next time someone touches the impacted code.
LGTM except for a couple of small nits:
Updated. |
Fixed. |
Needs rebase, sorry. I guess we should merge this before any other PRs it might conflict with. |
Updated. |
No description provided.