Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Harvester conditional. #19373

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Make Harvester conditional. #19373

merged 1 commit into from
Jul 12, 2021

Conversation

MustaphaTR
Copy link
Member

I'll probably need this for YR Slaves so free ones can't mine. Disabling the trait removes the resources stored in the vehicle.

Testcase makes having Radar Dome disable the Ore Miners.

@reaperrr
Copy link
Contributor

Harvester must override ConditionalTrait's Created method instead of implementing INotifyCreated directly

@MustaphaTR
Copy link
Member Author

Updated.

@MustaphaTR
Copy link
Member Author

Updated.

@MlemandPurrs
Copy link

oh great. this will also help them getting paused while EMP'ed.

@MustaphaTR
Copy link
Member Author

MustaphaTR commented May 5, 2021 •
edited
Loading

Updated.

Also i just realised i didn't put the testcase on a seperate commit, so don't merge with it by mistake.

@MustaphaTR
Copy link
Member Author

Updated.

pchote
pchote previously approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Testcase will need to be removed before merging.

Smittytron
Smittytron previously approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remove testcase.

@MustaphaTR MustaphaTR dismissed stale reviews from Smittytron and pchote via 841c90c July 12, 2021 06:49
@MustaphaTR
Copy link
Member Author

Removed the testcase.

@abcdefg30 abcdefg30 merged commit dcb70d1 into OpenRA:bleed Jul 12, 2021
@abcdefg30
Copy link
Member

Changelog

@MustaphaTR MustaphaTR deleted the conditional-harvester branch July 12, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@pchote pchote pchote left review comments

@Smittytron Smittytron Smittytron left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MustaphaTR @reaperrr @MlemandPurrs @abcdefg30 @pchote @Smittytron