Refactor PathGraph. #19532
Closed
Refactor PathGraph. #19532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please determine if you'd like to keep this prior to other major upcoming path graph changes. |
anvilvapre
force-pushed
the
20210716_perf_path_query
branch
from
86cb07a
to
235855c
Compare
|
rebased. |
|
I ended up with a similar flavour of changes in #19591 although the specifics did come out a bit different. Mentioning just to surface awareness of merge conflicts. |
|
This needs another rebase now. |
|
Please decide if you want some of these changes. I won't feel like rebasing/re-implementing them myself a third time. So I will close this pull request in future. |
|
Tbh, I don't know. Most changes in this PR seem to be superseded, so it might make sense to just close this and start anew if you feel there can still be optimizations (or just leave it as is). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
PathQueryto split parameters from actual implementation and to be able to share parameters betweenPathSearchandPathGraph.Removed
IPathSearch. Removed semi builder pattern fromPathSearch. Reduced the spread of state variables across 4 classes.Future improvements likely possible. Too many
Path*types for my taste.No functional change intended. In rare situation a path search can result in a slightly different path - this is intended. This may break sync on older replays. See original comment.
Originally part of a separate pull request that I will close in future #19245 (comment).