Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed suicides counting as kill in the game score #19625

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Fixed suicides counting as kill in the game score #19625

merged 1 commit into from
Sep 2, 2021

Conversation

Mailaender
Copy link
Member

Closes #19613

abcdefg30
abcdefg30 requested changes Aug 23, 2021
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to update the Army and Assets values when the unit dies.

@Mailaender
Copy link
Member Author

Ah, yes correct. Updated.

abcdefg30
abcdefg30 previously approved these changes Aug 24, 2021
View reviewed changes
@dnqbob
Copy link
Contributor

dnqbob commented Aug 25, 2021

with this fix we can let poison that lethal finally achieve without bug

@reaperrr reaperrr merged commit 978de64 into OpenRA:bleed Sep 2, 2021
@reaperrr
Copy link
Contributor

reaperrr commented Sep 2, 2021

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/d78a43ffd7ec82cfe949ea90b3e35c8a876a53c5...a6efcfa1e2986afcf0d4fcbc65525efd8bf30303

@Mailaender Mailaender deleted the suicide-stats branch September 4, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChangesHealth and killself count the actor killed scores to owner Player
4 participants
@Mailaender @dnqbob @reaperrr @abcdefg30