Added more code style rules #19871
Merged
Added more code style rules #19871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penev92
force-pushed
the
codeStyleRules
branch
from
091cad9
to
31a0e0a
Compare
pchote
reviewed
Jan 9, 2022
|
To resolve the issue of the style inside |
penev92
force-pushed
the
codeStyleRules
branch
2 times, most recently
from
f0f5554
to
e757447
Compare
RoosterDragon
previously approved these changes
Jan 10, 2022
Mailaender
added
PR: Fixup requested
PR: Needs +2
and removed
PR: Fixup requested
labels
|
Added two more commits - one to change |
RoosterDragon
previously approved these changes
Jan 13, 2022
Changed all currently present zero-length array allocations in the codebase to use `Array.Empty` instead.
Having this set to "none" disabled the IDE's option to add braces, whereas "silent" lets it do it on the user's request while still not suggesting it on its own.
penev92
force-pushed
the
codeStyleRules
branch
from
3d14c3b
to
666e2e5
Compare
|
Rebased. Only changes are to the comments in |
RoosterDragon
previously approved these changes
Jan 19, 2022
To order them by their number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of my recent efforts to finally have our toolchain enforce our long-standing code style rules.
Follow-up of #19747 and #19801, this adds
twothree more rules to.editorconfigto treattwothree more suggestions as warnings, which the CI then treats as errors.Calling @RoosterDragon.