New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beautified the .editorconfig file #19873
Conversation
Hopefully we cleared the concerns in Discord. |
Alright, since @abcdefg30 didn't post this here I'll guess I'll have to do it for him:
And hence the "Conceptual concerns" label above. Now, as was explained on Discord, same-line comments are perfectly valid, and in some cases preferable. For some weird reason OpenRA has a rule against those (which I say we remove anyway) in C# code, but it's debatable whether that applies here. |
Initially I would have let this slip through, but you have made it abundantly clear that you want to use this as precedent for changing the global style rules. You wrote yourself that same-line comments are a matter of taste. It is not my responsibility to proof that our style rules should not be changed; especially not when even you say it's just about personal taste. Do whatever you want with the style in the config file; I have no interest in reviewing or discussing it further. |
https://editorconfig.org/#file-format-details
🙊 |
One could still make a bunch of arguments why that's silly (like this makes it many times less readable and also when have we ever followed standard code style conventions) but at least this is now more than a whim so whatever, I'll change it.... P.S.: Thanks for the link @matjaeck |
Slight reformatting of the
.editorconfig
file triggered by #19871 (comment)I fixed comments, added some hopefully clearer explanations and some fun facts like some things are probably duplicates of StyleCop rules. No functional changes here, just formatting. Changes will come in the next 2 PRs.
Is dependency for #19871.
Pinging @RoosterDragon for this one as well.