Create overlays dropdown #19895
Merged
Create overlays dropdown #19895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
commented
Jan 23, 2022
| Height: 25 | ||
| Text: Buildable | ||
| Font: Bold | ||
| Key: f2 |
There was a problem hiding this comment.
I don't reimplement hotkeys in this pr. They need to be handled differently not just because of the dropdown works, but also because they aren't editable by users in the hotkeys menu
There was a problem hiding this comment.
I added the hotkey just because everything else had one, but I don't think this requires a quick keyboard access.
There was a problem hiding this comment.
I think having those on hotkeys could lead to a smoother workflow. Regardless I believe we should have a dropdown class and unhardcode values into yaml. That could also allow for a smoother reimplementation of hotkeys
There was a problem hiding this comment.
but that would be worthy of a separate pr
Mailaender
approved these changes
Jan 23, 2022
abcdefg30
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to group overlays, I made Grid and Buildable into a dropdown. This is also future proofing incase we want to add more overlays