New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a script triggers overlay #19745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
script-overlay
branch
from
October 12, 2021 20:12
4d5c57c
to
a9eb0aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine and appears sensible, some minor thoughts added.
Mailaender
force-pushed
the
script-overlay
branch
from
November 19, 2021 19:11
a9eb0aa
to
5511bbb
Compare
Thanks for the review. Updated accordingly. |
RoosterDragon
previously approved these changes
Nov 20, 2021
teinarss
reviewed
Apr 2, 2022
Mailaender
force-pushed
the
script-overlay
branch
from
April 2, 2022 15:16
5511bbb
to
ac22962
Compare
Also needs a rebase |
Mailaender
force-pushed
the
script-overlay
branch
from
April 2, 2022 15:50
ac22962
to
e25ee5c
Compare
Rebased after #19895 |
teinarss
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accessible by debug command.