Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a script triggers overlay #19745

Merged
merged 2 commits into from Apr 2, 2022
Merged

Conversation

Mailaender
Copy link
Member

accessible by debug command.

Copy link
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine and appears sensible, some minor thoughts added.

OpenRA.Mods.Common/Traits/World/ActorMap.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/World/TriggerOverlay.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/World/TriggerOverlay.cs Outdated Show resolved Hide resolved
@Mailaender
Copy link
Member Author

Thanks for the review. Updated accordingly.

RoosterDragon
RoosterDragon previously approved these changes Nov 20, 2021
@teinarss
Copy link
Contributor

teinarss commented Apr 2, 2022

Also needs a rebase

@Mailaender
Copy link
Member Author

Rebased after #19895

@teinarss teinarss merged commit 7735107 into OpenRA:bleed Apr 2, 2022
@Mailaender Mailaender deleted the script-overlay branch April 2, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants