Added filtering by asset type in the AssetBrowser

[penev92]

Closes #3493.

[dragunoff]

Please add some padding around the checkboxes:

See this for reference:

Perhaps we need a better way to create this kind of dropdowns as they are used in several places and as far as remember setting them up them is a bit of a pain.

And on another note - what do we gain from listing unknown types? The asset browser won't be able to display them anyway, right?

[penev92]

I added spacing:

Do you want me to do the same for this dropdown in the editor, on which I based mine?

I added a filter to not show "non-asset" files (and packages) by excluding unsupported files that are inside the EngineDir. This is what the result looks like:

You will notice the audio files in yellow that are not consider "supported" by the asset browser and thus not shown by default.
OK I realized this was a bad example while writing that and fixed the asset browser's supported extensions instead. In any case, with the junk files gone I again feel it is worth to have an actual asset *browser* that can show you the contents of packages.

[dragunoff]

Do you want me to do the same for this dropdown in the editor, on which I based mine?

Yes, that would be a nice polish up. This one too, please:

[penev92]

Added spacing in map editor dropdowns, added missing file extension to AssetBrowser in mod manifests and added a filter to not show engine files.

[dragunoff]

Overall this looks good but I noticed a couple of things:

1. Directories are listed as unknown assets but they cannot be clicked on. Shouldn't we filter dirs out of this list?
   
2. The scrollpane doesn't update when it's scrolled to the bottom an switching to a list with fewer items:

output.mp4

output.mp4

[penev92]

The change to fix 1. is squashed into the relevant commit, but here it is standalone:

--- a/OpenRA.Mods.Common/Widgets/Logic/AssetBrowserLogic.cs
+++ b/OpenRA.Mods.Common/Widgets/Logic/AssetBrowserLogic.cs
 	// Don't show unknown files in the engine dir - it is full of code and git and IDE files.
 	// But do show supported types that are inside just in case.
+	// Also don't show "files" without extensions because those may be folders.
 	var fileExtension = Path.GetExtension(file.Key.ToLowerInvariant());
-	if (package.Name == Platform.EngineDir && !allowedExtensions.Contains(fileExtension))
+	if (string.IsNullOrWhiteSpace(fileExtension) || (package.Name == Platform.EngineDir && !allowedExtensions.Contains(fileExtension)))
 		continue;
 
 	AddAsset(assetList, file.Key, package, template);

The change to fix 2. got its own commit.

[abcdefg30]

Re #20025 (comment): Why do we have to check if there is an extension to determine if it is a folder, and can't use something like IsDirectory or Directory.Exists? (Are we talking about directories inside packages?)

[penev92]

Are we talking about directories inside packages?

Yes, we're talking about "entries" inside packages, so we can't really check and we resort to guessing.

Also rebased.

[dragunoff]

LGTM 👍

[abcdefg30]

The engine dir problem could also be solved by introducing a blacklist. We currently also display .yaml files in the assets browser which we don't need to...

On a different note, we should think about making the dropdowns in cnc a bit more opaque.

[abcdefg30]

I don't really like this, as it is hidden and not visible to the outside at all. Besides, when you select unknown, aren't you exactly asking for this? A much better fix would be making the list with packages also one where you can tick/untick packages and maybe have the engine dir unticked by default? (Fwiw, several of the files in the engine dir will already be filtered by the "no extension" rule.)

[penev92]

when you select unknown, aren't you exactly asking for this?

Yes, but I was previously asked to hide engine files so I added this 🤷‍♂️

[penev92]

A much better fix would be making the list with packages also one where you can tick/untick packages and maybe have the engine dir unticked by default?

I agree it would be good, but not in this PR (although that doesn't mean I'm volunteering to do it later either, sorry).

I could add a blacklist, but what do we put in there - extensions? Packages? File names?

Honestly I would like to wrap this (supposedly simple) feature up because the more I stare at the AssetBrowserLogic code the more issues I find that need fixing.

Rebased and fixed the minor nit.

[PunkPun]

Otherwise LGTM. This PR is fixing tiny things all over the codebase which are completely unrelated to this PR and be better served in separate PR's. It just unnecessarily makes it harder to merge this

[penev92]

Rebased, dropping 4 of the 7 commits as they were merged in #20235.
This PR is now all about filtering the assets.

[PunkPun]

Changelog