Scripts: Disable markup in error messages #20072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error messages are displayed using the following methods: * **zenity** parses pango markup and replaces escaped characters * **kdialog** replaces (some) escaped characters * **gtk-dialog.py** replaces `\n` * **printf** interprets format strings and replaces escaped characters * **echo** just displays the text The error messages themself contain escaped characters and paths from variables. This PR unifies the behavior by: * Use **printf** to format error messages and replace escaped characters * Setting `--no-markup` for **zenity** to disable pango markup and escaped characters * Remove `\n` replacement from **gtk-dialog.py**. * Use plain **echo** instead of **printf**
pchote
previously approved these changes
Jun 24, 2022
anvilvapre
reviewed
Jun 25, 2022
anvilvapre
previously approved these changes
Jun 25, 2022
As mentioned in OpenRA#20059 (comment)
abcdefg30
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages are displayed using the following methods:
\nThe error messages themself contain escaped characters and paths from variables.
This PR unifies the behavior by:
--no-markupfor zenity to disable pango markup and escaped characters\nreplacement from gtk-dialog.py.