Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Disable markup in error messages #20072

Merged
merged 2 commits into from Jul 10, 2022

Commits on Jun 14, 2022

  1. Scripts: Disable markup in error messages

    Error messages are displayed using the following methods:
    
    * **zenity** parses pango markup and replaces escaped characters
    * **kdialog** replaces (some) escaped characters
    * **gtk-dialog.py** replaces `\n`
    * **printf** interprets format strings and replaces escaped characters
    * **echo** just displays the text
    
    The error messages themself contain escaped characters and paths from variables.
    
    This PR unifies the behavior by:
    
    * Use **printf** to format error messages and replace escaped characters
    * Setting `--no-markup` for **zenity** to disable pango markup and escaped characters
    * Remove `\n` replacement from **gtk-dialog.py**.
    * Use plain **echo** instead of **printf**
    Unrud committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0666b0f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Use python3 for gtk-dialog.py

    As mentioned in OpenRA#20059 (comment)
    Unrud committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    a106a65 View commit details
    Browse the repository at this point in the history