Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make game timer only blink on pause #20116

Merged
merged 1 commit into from Aug 8, 2022
Merged

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Jul 8, 2022

fixes #16676

Now when a UI doesn't define GAME_TIMER_STATUS the timer will only blink when game is paused

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RA mod has no indicator any more for when the game is paused (not watching a replay).

@PunkPun
Copy link
Member Author

PunkPun commented Jul 13, 2022

fixed

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something weird is going on now: When spectating replays at speeds different to 100% the timer blinks with "Paused".

@PunkPun PunkPun dismissed abcdefg30’s stale review July 27, 2022 09:25

When the replay ends the phrase "Paused" is blinked regardless of what you do. This is not a regression

@anvilvapre
Copy link
Contributor

calculating twice if current game tick is an even second.
calculating each render the formatted string for the current world tick.
perhaps you could use cached transforms.
or receive tick events and only then update getText() values.

@PunkPun
Copy link
Member Author

PunkPun commented Aug 1, 2022

perhaps you could use cached transforms.

That would make sense, even if its performance impact is minute. Perhaps in another PR

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the replay ends the phrase "Paused" is blinked regardless of what you do. This is not a regression

Yep that must have been it, my bad.

Copy link
Contributor

@dragunoff dragunoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as promised 👍

Perhaps it would be nice to blink "Game ended" or something like that instead of "Paused" when the replay is over but this is work for a follow-up.

@abcdefg30 abcdefg30 merged commit fd9758d into OpenRA:bleed Aug 8, 2022
@PunkPun PunkPun deleted the fix-timer-status branch August 8, 2022 08:48
@abcdefg30
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In replays when 50%, 200% or Max speed is chosen the timer is repeatedly blocked
5 participants