New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make game timer only blink on pause #20116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RA mod has no indicator any more for when the game is paused (not watching a replay).
de62de6
to
9510277
Compare
fixed |
9510277
to
54a3421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something weird is going on now: When spectating replays at speeds different to 100%
the timer blinks with "Paused".
When the replay ends the phrase "Paused" is blinked regardless of what you do. This is not a regression
calculating twice if current game tick is an even second. |
That would make sense, even if its performance impact is minute. Perhaps in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the replay ends the phrase "Paused" is blinked regardless of what you do. This is not a regression
Yep that must have been it, my bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as promised 👍
Perhaps it would be nice to blink "Game ended" or something like that instead of "Paused" when the replay is over but this is work for a follow-up.
fixes #16676
Now when a UI doesn't define
GAME_TIMER_STATUS
the timer will only blink when game is paused