Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShroudRenderer, fix, render Shroud if fog disabled. #20245

Merged

Conversation

anvilvapre
Copy link
Contributor

Closes #20243.

  • Fix: only check for (visible under) Explored not both Visible or Explored.
  • Fix: shroud covered == not explored, visible may still be true when fog is disabled
  • Optimization: fogEnabled over FogEnabled

@PunkPun PunkPun added this to the Next release milestone Sep 1, 2022
PunkPun
PunkPun previously approved these changes Sep 2, 2022
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This also fixes another regression that I just noticed. When you use /visibility command it no longer explores the map permanently. This behaviour matches last release

MustaphaTR
MustaphaTR previously approved these changes Sep 2, 2022
Copy link
Member

@MustaphaTR MustaphaTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that fixes #20243. Didn't notice any other issues while testing.

@dragunoff
Copy link
Contributor

This doesn't seem correct (see minimap):
Screenshot from 2022-09-02 14-38-26

To reproduce:

  1. Start a game with "Explored Map: On" and "Fog of War: Off"
  2. Enable "all" cheat.
  3. Build a radar dome and a power plant.
  4. Disable "all" cheat.
  5. Observe minimap.

@anvilvapre anvilvapre dismissed stale reviews from MustaphaTR and PunkPun via 8751464 September 2, 2022 13:01
@anvilvapre anvilvapre force-pushed the 20220901_shroud_renderer_edges_fix branch from b43729f to 8751464 Compare September 2, 2022 13:01
@anvilvapre
Copy link
Contributor Author

Can only validate myself in the evening. But this may fix it. Untested. Same issue as in shroud renderer, but now in radar widget.

@anvilvapre
Copy link
Contributor Author

Assuming the issue was that the radar/minimap did not show the shroud. I can confirm this has been fixed.

You mentioned: Start a game with "Explored Map: On" and "Fog of War: Off". But I assume you also later pressed the "Reset shroud" button, or had explored map off? I.e. how else could your screenshot have a shroud in the main view?

@dragunoff
Copy link
Contributor

Assuming the issue was that the radar/minimap did not show the shroud. I can confirm this has been fixed.

You mentioned: Start a game with "Explored Map: On" and "Fog of War: Off". But I assume you also later pressed the "Reset shroud" button, or had explored map off? I.e. how else could your screenshot have a shroud in the main view?

I used the /all cheat. I guess it resets shroud when disabled.

@Smittytron Smittytron merged commit 57ce88c into OpenRA:bleed Sep 3, 2022
@Smittytron
Copy link
Member

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shroud does not render when FoW is disabled.
6 participants