Disallow Join button without IP address input #20272
Conversation
| @@ -39,6 +39,8 @@ public DirectConnectLogic(Widget widget, Action onExit, Action openLobby, Connec | |||
| portField.Text = text.Substring(last + 1); | |||
| } | |||
|
|
|||
| panel.Get<ButtonWidget>("JOIN_BUTTON").IsDisabled = () => string.IsNullOrEmpty(ipField.Text); | |||
There was a problem hiding this comment.
It's more optimal to reuse the search
| panel.Get<ButtonWidget>("JOIN_BUTTON").IsDisabled = () => string.IsNullOrEmpty(ipField.Text); | |
| var joinButton = panel.Get<ButtonWidget>("JOIN_BUTTON"); | |
| joinButton.IsDisabled = () => string.IsNullOrEmpty(ipField.Text); |
and reuse it on OnClick
|
Fixes #20234 also works, just without the brackets |
|
Can you squash the commits, please? |
Disallow join button without IP address Input Closes OpenRA#20234 Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input. Updated to reuse search for joinButton vs 2 separate calls to search.
The-Zen-Cat
force-pushed
the
jointservercrash
branch
from
818a4f8
to
b2e6d94
Compare
There was a problem hiding this comment.
LGTM 👍
However I think that while this works it has a problem with feedback - the user can't easily tell what is preventing them from pressing the button. It's not so evident in this example but in a more complex form where validation depends on several inputs (like the save map dialog in #20274) it may be difficult to tell where the errors are.
So we should give some feedback about what is wrong - for example in the tooltip text of the button. Perhaps an even better approach is to not disable the button, let the user press it and then highlight the invalid fields. In any case this is not something we need to solve now.
We could highlight the empty fields |
Closes #20234
Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input.