Tiberian Dawn Lua code cleanup #20275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
cnc-lua-cleanup
branch
from
fe7392b
to
53a9f26
Compare
abcdefg30
previously approved these changes
Sep 9, 2022
anvilvapre
reviewed
Sep 10, 2022
| @@ -158,30 +158,30 @@ Trigger.OnAllKilledOrCaptured(GDIBase, function() | |||
| Utils.Do(GDI.GetGroundAttackers(), IdleHunt) | |||
| end) | |||
|
|
|||
| Trigger.OnKilled(GDIProc, function(building) | |||
| Trigger.OnKilled(GDIProc, function() | |||
There was a problem hiding this comment.
LUA is flexible in the type of function that you pass?
I will also not lead to a memory leak of the building argument. I guess it's reference counted and it won't.
There was a problem hiding this comment.
Yes, you don't need to specify the parameters if you don't use them.
There was a problem hiding this comment.
The IDE showed it as greyed out, but didn't issue a warning.
Uppercase global variables. Declare local variables. Remove unused variable.
Mailaender
force-pushed
the
cnc-lua-cleanup
branch
from
53a9f26
to
a188c91
Compare
RoosterDragon
approved these changes
Sep 10, 2022
PunkPun
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #20265.