New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize orders for all clients #20486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't spot any issues
I haven't try it yet, but do you test this on https://github.com/ABrandau/Shattered-Paradise-SDK/tree/Sync-test2? |
Also there is a thought: We can also drop the generation code serialization in #20084, becuase we now make all client serialize/deserialize order, @abcdefg30
Now we basically fall back to just serializing and deserializing local orders again, right? maybe other related PRs can be also closed/reverted due to this PR. |
This is more meant as short term fix, in the long run the local orders shouldn't be serialized and deserialized. |
Then I will reopen #20479. |
Fixes #20478.
Supersedes #20479.
This implements a cleaner solution that more closely matches the behaviour before the orders rewrite.