-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more Code Quality Rules #20812
Conversation
7393db6
to
fcf861f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with CA1816. All these classes should be inheritable.
For things like traits I wouldn't necessarily disagree, but the cases here are internal engine types that don't make much sense to subclass (with the exception of |
fcf861f
to
49dc3c2
Compare
For CA1816 I don't see a good reason to allow inheritance for any of them. They've got no protected or virtual methods, they've got no behaviour a derived class could customize (except |
49dc3c2
to
629b04f
Compare
629b04f
to
b6016c9
Compare
aa5f992
to
1c3c5df
Compare
1c3c5df
to
43f4162
Compare
Following on from #20802
Enforces 5 code quality rules across the project.
I have batched together a PR for these rules as they each had some but not too many violating files.
See https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ for explanation of each rule.