Enable 2 more Code Quality Rules #20814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
force-pushed
the
style-ca-large
branch
from
ec650bb
to
6340ab5
Compare
Mailaender
previously approved these changes
Apr 25, 2023
RoosterDragon
force-pushed
the
style-ca-large
branch
from
6340ab5
to
55048c8
Compare
|
The rules are fine, but |
|
Future PRs that make things public can choose to unseal them at the same time if it is appriopriate. |
RoosterDragon
force-pushed
the
style-ca-large
branch
from
55048c8
to
6c12ff9
Compare
RoosterDragon
force-pushed
the
style-ca-large
branch
from
6c12ff9
to
ddb5038
Compare
|
Seems like this needs a rebase again. |
RoosterDragon
force-pushed
the
style-ca-large
branch
from
ddb5038
to
52fdcc0
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #20802, #20812
Enforces 2 code quality rules across the project. I have batched together a PR for these rules as the diff is large but boring.
See https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ for explanation of each rule.