Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IntegerExpressions for Chrome Layout (again) #20877

Merged
merged 3 commits into from
Jun 4, 2023
Merged

Use IntegerExpressions for Chrome Layout (again) #20877

merged 3 commits into from
Jun 4, 2023

Conversation

Mailaender
Copy link
Member

@Mailaender Mailaender commented May 20, 2023 •
edited
Loading

This reverts #13601. Closes #13526 as since #20765 we now target Mono 6.12.0

abcdefg30
abcdefg30 previously approved these changes May 24, 2023
View reviewed changes
@PunkPun
Copy link
Member

PunkPun commented May 30, 2023 •
edited
Loading

Entering RA game lobby crashes instantly

Exception of type `OpenRA.YamlException`: Missing whitespace at index 2, before `*` operator.
   at OpenRA.FieldLoader.ParseIntegerExpression(String fieldName, Type fieldType, String value, MemberInfo field) in /OpenRA.Game/FieldLoader.cs:line 342

@Mailaender
Copy link
Member Author

Fixed and added a lint test.

@Mailaender Mailaender changed the title Revert "Revert "Replace legacy Evaluator with IntegerExpressions."" Use IntegerExpressions for Chrome Layout (again) May 30, 2023
@RoosterDragon
Copy link
Member

Noticed one regression:
Multiplayer menu (common)

Bleed
image

PR
image

but otherwise flicking through various UI everything seemed good.

@Mailaender
Copy link
Member Author

Fixed.

RoosterDragon
RoosterDragon previously approved these changes Jun 3, 2023
View reviewed changes
@anvilvapre
Copy link
Contributor

anvilvapre commented Jun 3, 2023 •
edited
Loading

Side remark. Popovers are also widgets. These get loaded each time and often at each mouse move. There might be situations where the integer expresions are evaluated very often? But perhaps in the old situation it was not much more efficent?

@PunkPun PunkPun merged commit e164e48 into OpenRA:bleed Jun 4, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Jun 4, 2023

Changelog

@Mailaender Mailaender deleted the revert-revert-evaluator branch June 4, 2023 21:16
@Mailaender Mailaender mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@PunkPun PunkPun PunkPun approved these changes

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntegerExpressions are slooow, causing UI lag
5 participants
@Mailaender @PunkPun @RoosterDragon @anvilvapre @abcdefg30