Fixed a crash after changing the display scale #20990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mailaender
force-pushed
the
recalc-ui-scale
branch
from
515dded
to
d1822d2
Compare
|
This seems to fix the issue. Though I'm not sure why we need to use a readonly dictionary here? Also maybe fixing the bug here is not addressing the issue at the core? Sorry I don't have time to investigate |
Mailaender
changed the title
|
If you have a look at #20877 you can see that I am using the exact same pattern for safe evaluations. |
PunkPun
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #20877 and an attempted fix for #20951 which I can't reproduce as the option is not available to me.