Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More chrome string translation preparations #20883

Merged
merged 3 commits into from Aug 8, 2023

Conversation

Mailaender
Copy link
Member

These are also required for #20594.

@PunkPun
Copy link
Member

PunkPun commented May 21, 2023

Last commit should be merged into the first, or another way around where the yaml changes are moved to last commit

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

mods/cnc/chrome/settings-display.yaml Show resolved Hide resolved
PunkPun
PunkPun previously approved these changes May 23, 2023
@PunkPun
Copy link
Member

PunkPun commented Jul 25, 2023

Needs a rebase

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As LaberWithHighlightWidgets is used by some buttons, you also need to go through TooltipDesc: and correct them. For example I see errors in ingame.yaml

@Mailaender
Copy link
Member Author

Fixed and added the < brackets > to forbidden player names.

@PunkPun PunkPun merged commit 0528ef5 into OpenRA:bleed Aug 8, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Aug 8, 2023

Changelog

@Mailaender Mailaender deleted the l10n-chrome-prep branch August 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants