New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More chrome string translation preparations #20883
Conversation
Last commit should be merged into the first, or another way around where the yaml changes are moved to last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
2fda2cb
to
a2e3811
Compare
Needs a rebase |
a2e3811
to
953c4d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As LaberWithHighlightWidgets
is used by some buttons, you also need to go through TooltipDesc:
and correct them. For example I see errors in ingame.yaml
953c4d1
to
aa2cf31
Compare
Fixed and added the |
These are also required for #20594.