More chrome string translation preparations#20883
Merged
PunkPun merged 3 commits intoOpenRA:bleedfrom Aug 8, 2023
Merged
Conversation
Member
|
Last commit should be merged into the first, or another way around where the yaml changes are moved to last commit |
Mailaender
force-pushed
the
l10n-chrome-prep
branch
from
2fda2cb to
a2e3811
Compare
PunkPun
previously approved these changes
May 23, 2023
Member
|
Needs a rebase |
Mailaender
force-pushed
the
l10n-chrome-prep
branch
from
a2e3811 to
953c4d1
Compare
PunkPun
reviewed
Jul 26, 2023
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
As LaberWithHighlightWidgets is used by some buttons, you also need to go through TooltipDesc: and correct them. For example I see errors in ingame.yaml
Mailaender
force-pushed
the
l10n-chrome-prep
branch
from
953c4d1 to
aa2cf31
Compare
Member
Author
|
Fixed and added the |
PunkPun
approved these changes
Aug 8, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are also required for #20594.