Minelaying improvements

[michaeldgg2]

Second PR with Minelayer improvements:

1. option to specify time it takes to lay a mine
2. delay after mine has been laid is now customizable (previously hardcoded to 20 ticks)
3. Minelayer exposes static method for creating BeginMinefield order

No. 3 is useful for mods that would want to change the way this feature is activated.

[PunkPun]

No changes were pushed

[michaeldgg2]

I did mess up the first push (with the fixes), but the second push went through (though I forgot about the Wait in FinishLayingMine). Now it should be complete (including the fix for empty ammo pool).

It seems that the GitHub's Compare feature between two commits (where one or both could be already "force-pushed" out of the repo) isn't working properly, because Commits and Files tabs show the changes correctly.

[PunkPun]

you just removed MineLaidDelay, and didn't really push any of the changes

[michaeldgg2]

In order to make cancellation of mine laying work correctly, I had to add another method to INotifyMineLaying to notify other traits that the laying process was canceled.

Also LayMine still has to return bool and false, if the ammo pool doesn't have enough ammo. Because theoretically other trait could take ammo from that ammo pool during PreLayDelay (and thus LayMines activity would lay a mine without actually adhering to ammo pool restriction).

This is how the minelayer unit looks in OpenE2140 with current changes in the PR. I made a custom and very simple WithDeployMineAnimation trait that takes advantage of INotifyMineLaying. Since I'm planning on making another PR with improvements to minelaying, so I could throw that in, if you'd like.

[PunkPun]

Final nits, otherwise LGTM

[Mailaender]

Changelog