Installers: Fix Steam library manifest parsing. #21140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
changed the title
pchote
reviewed
Oct 29, 2023
OpenRA.Mods.Common/Installer/SourceResolvers/SteamSourceResolver.cs
Outdated
Show resolved
Hide resolved
tinix0
force-pushed
the
steam-library-path-parsing-fix
branch
from
44384dd
to
eb03445
Compare
RoosterDragon
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
Confirmed working for me.
The yield return libraryPath; line for me gives C:\Program Files (x86)\Steam which succeeds and skips the later logic. So that might explain why this wasn't noticed - on my machine and presumably others that didn't use a different install dir it was never executed. But if I comment that out and force it to check the inside libraryfolders.vdf that does indeed return C:\\Program Files (x86)\\Steam and the new unespacing logic fixes that into a valid path.
PunkPun
reviewed
Nov 4, 2023
PunkPun
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21129.
Steam library paths stored in manifest files have escaped backslashes on Windows and need to be unescaped. This either never worked on Windows or regressed since it was implemented.