Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IRenderPostProcessPass texture unit binding. #21153

Merged
merged 1 commit into from Oct 25, 2023

Conversation

pchote
Copy link
Member

@pchote pchote commented Oct 24, 2023

shader.SetTexture() caches state that is then submitted by shader.PrepareRender(). Calling them in the correct order ensures that we aren't copying pixels from the wrong texture (e.g. unit sprite sheets...)

@dnqbob
Copy link
Contributor

dnqbob commented Oct 25, 2023

This PR fix #21152 on test.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I dunno wether this fixes the first frame on TS as the issue never appeared on my setup

@PunkPun PunkPun merged commit a3c0cee into OpenRA:bleed Oct 25, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Oct 25, 2023

Changelog

@pchote pchote deleted the fix-postprocess-texture-binding branch October 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants