Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Cloak palette effects with vertex effects #21215

Merged
merged 3 commits into from Dec 4, 2023

Conversation

pchote
Copy link
Member

@pchote pchote commented Nov 15, 2023

This PR replaces the palette effects used by RA/D2k/TS with visually equivalent vertex effects, and changes TD to use the same translucency as the other mods. This also implements a smooth fading to/from cloak.

cloak.mov

These new effects are compatible with 32-bit sprites, needed for TDHD and D2kHDR.

Closes #19263.

@PunkPun
Copy link
Member

PunkPun commented Nov 15, 2023

Related #12195, #19263, #14987, #12237

@pchote
Copy link
Member Author

pchote commented Nov 15, 2023

This actually doesn't solve #12237, but we could do that if wanted.

@PunkPun
Copy link
Member

PunkPun commented Nov 15, 2023

it would be most helpfull

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO cloak sound should play when the unit starts to cloak / uncloak, rather when the cloak completes. Phase transport and stealth tanks currently feel weird because of it.

Submaries should also transition instantly. The fade really doesn't work for them, if it's to be not instant they need a custom animation instead

As for stealth tanks, aren't they supposed to have a shine? A glint?

In TS there seems to be a regression. When I open the shellmap the civilian buildings fade in. Also in TS units seem to become whiter when stealthed instead of just transparent.

@pchote
Copy link
Member Author

pchote commented Nov 15, 2023

Removed the transition commit. This is now focused just on the TDHD compatibility.

@pchote
Copy link
Member Author

pchote commented Nov 16, 2023

Rewritten again to keep CloakStyle.Palette for TD, and as the default (so no need for update rules).

Edit: FFS...

@pchote
Copy link
Member Author

pchote commented Nov 16, 2023

Updated, again.

@pchote
Copy link
Member Author

pchote commented Nov 17, 2023

Updated to fix TD.

@pchote
Copy link
Member Author

pchote commented Dec 2, 2023

Rebased and pulled in @PunkPun's update rule changes (not tested).

@PunkPun
Copy link
Member

PunkPun commented Dec 2, 2023

There seems to be issues with tabs and whitespaces

@pchote pchote force-pushed the alpha-cloak branch 2 times, most recently from 8d35d39 to c5aae4d Compare December 2, 2023 20:40
@pchote
Copy link
Member Author

pchote commented Dec 2, 2023

Fixed whitespace.

OpenRA.Mods.Common/Traits/Cloak.cs Outdated Show resolved Hide resolved
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PunkPun PunkPun merged commit dd7441e into OpenRA:bleed Dec 4, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Dec 4, 2023

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Cloak palette override and reimplement using alpha
3 participants