New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Cloak palette effects with vertex effects #21215
Conversation
This actually doesn't solve #12237, but we could do that if wanted. |
it would be most helpfull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO cloak sound should play when the unit starts to cloak / uncloak, rather when the cloak completes. Phase transport and stealth tanks currently feel weird because of it.
Submaries should also transition instantly. The fade really doesn't work for them, if it's to be not instant they need a custom animation instead
As for stealth tanks, aren't they supposed to have a shine? A glint?
In TS there seems to be a regression. When I open the shellmap the civilian buildings fade in. Also in TS units seem to become whiter when stealthed instead of just transparent.
Removed the transition commit. This is now focused just on the TDHD compatibility. |
Rewritten again to keep Edit: FFS... |
Updated, again. |
OpenRA.Mods.Common/UpdateRules/Rules/20231010/ReplaceCloakPalette.cs
Outdated
Show resolved
Hide resolved
Updated to fix TD. |
OpenRA.Mods.Common/UpdateRules/Rules/20231010/ReplaceCloakPalette.cs
Outdated
Show resolved
Hide resolved
Rebased and pulled in @PunkPun's update rule changes (not tested). |
There seems to be issues with tabs and whitespaces |
8d35d39
to
c5aae4d
Compare
Fixed whitespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR replaces the palette effects used by RA/D2k/TS with visually equivalent vertex effects, and changes TD to use the same translucency as the other mods. This also implements a smooth fading to/from cloak.
cloak.mov
These new effects are compatible with 32-bit sprites, needed for TDHD and D2kHDR.
Closes #19263.