New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use higher colour depth R16 sprites in D2k. #21240
Conversation
I tagged a test build for anyone who wants to try this (but remember that the asset download still requires the website PR to be merged) https://github.com/pchote/OpenRA/releases/tag/devtest-20231206 |
Required patch 1.06 is not on any ISO and cant be downloaded. Manual extraction of 1.06 into V3 folder also dont work. Is there any other option here? |
Options:
|
I found R16 Rocktiles: I will add them in my own PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged OpenRA/OpenRAWebsiteV3#52
and a crash
Exception of type `System.NullReferenceException`: Object reference not set to an instance of an object.
at OpenRA.Renderer.Dispose() in OpenRA/OpenRA.Game/Renderer.cs:line 537
at OpenRA.Game.Run() in OpenRA/OpenRA.Game/Game.cs:line 896
at OpenRA.Game.InitializeAndRun(String[] args) in OpenRA/OpenRA.Game/Game.cs:line 313
at OpenRA.Launcher.Program.Main(String[] args) in OpenRA/OpenRA.Launcher/Program.cs:line 32
Fixed the quickinstall download sha1 (it had incorrectly duplicated the patch106 hash) and rebased. I'm not able to reproduce the "mirror not available" or NRE errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The OG D2k shipped with a graphics option to use 8-bit or 16-bit sprites:
This PR completes the transition towards supporting non-paletted sprites as a first-class feature by switching D2k over to these higher colour sprites. The 16-bit and embedded-palette frames are converted to 32-bit when loaded, and remapped to player colours using the ColorShift logic.
The main disruption is that we did not previously install or download the R16 assets, so the content must be reinstalled. I have followed the example from the first time we did this by installing the new asset set to a
v3
subdirectory that is independent from thev2
used by current installs. OpenRA/OpenRAWebsiteV3#52 will need to be merged before the downloads will work.The actual visual improvements are subtle, and mainly visible in the explosion effects and sidebar icons. The quickest way to get an overview of the improvements is to use the
--dump-sequence-sheets
utility command before and after, then blink between the two versions.