Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace D2k 8-bit custom tiles with 16-bit equivalents #21258

Merged

Conversation

Porenutak
Copy link
Contributor

@Porenutak Porenutak commented Dec 15, 2023

Dependencies: #21240
Tested on devtest-20231206 version.
This PR replace .tmp custom tiles with R16 equivalents and add some new from #21221
Know issue:
I was unable to use PngSheet because utility convert it back to 8-bit. Instead I used standart R16 tileset format. But because Tileset editor require exact resolution (640x 1280) there is lots of unused frames there.
Tileset:
customtiles

Im planning to fill free frames in later PRs.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, need a rebase

@PunkPun
Copy link
Member

PunkPun commented Dec 20, 2023

Did you accidentally push balance changes into this PR?

@pchote
Copy link
Member

pchote commented Dec 20, 2023

Can we please move the customtiles.r16 from the tex subdirectory to bits?
The tex dir can then be removed from mod.yaml.

@pchote
Copy link
Member

pchote commented Dec 20, 2023

TmpRA can also be removed from SpriteFormats in mod.yaml.

@Porenutak Porenutak force-pushed the replace-tmp-tiles-with-R16-equivalents branch from 9485f37 to 9608523 Compare December 20, 2023 12:54
@Porenutak
Copy link
Contributor Author

Porenutak commented Dec 20, 2023

Sorry, I fuck up my rebase again :( .
customtiles.r16 moved to bits folder.
TmpRA was removed from mod.yaml (hope no custom map used any :D )

I check all custom tiles once more and fixed all pixel size errors. But should be check also by someone else.

@Porenutak
Copy link
Contributor Author

Is this PR working now? because it start crashing after I force push.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to be working for me.

.gitignore Outdated Show resolved Hide resolved
@Porenutak Porenutak force-pushed the replace-tmp-tiles-with-R16-equivalents branch 2 times, most recently from 2574d79 to aa788b3 Compare December 20, 2023 13:28
@PunkPun PunkPun force-pushed the replace-tmp-tiles-with-R16-equivalents branch from aa788b3 to 79fed68 Compare January 6, 2024 11:21
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couldn't find any regressions and @pchote gave a +2 on discord

@PunkPun PunkPun merged commit 0e5447d into OpenRA:bleed Jan 6, 2024
3 checks passed
@PunkPun PunkPun added this to the Next Release milestone Jan 6, 2024
@PunkPun
Copy link
Member

PunkPun commented Jan 6, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants