New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace D2k 8-bit custom tiles with 16-bit equivalents #21258
Replace D2k 8-bit custom tiles with 16-bit equivalents #21258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, need a rebase
af04c89
to
9485f37
Compare
Did you accidentally push balance changes into this PR? |
Can we please move the customtiles.r16 from the |
|
9485f37
to
9608523
Compare
Sorry, I fuck up my rebase again :( . I check all custom tiles once more and fixed all pixel size errors. But should be check also by someone else. |
Is this PR working now? because it start crashing after I force push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to be working for me.
2574d79
to
aa788b3
Compare
aa788b3
to
79fed68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couldn't find any regressions and @pchote gave a +2 on discord
Dependencies: #21240
Tested on devtest-20231206 version.
This PR replace .tmp custom tiles with R16 equivalents and add some new from #21221
Know issue:
I was unable to use PngSheet because utility convert it back to 8-bit. Instead I used standart R16 tileset format. But because Tileset editor require exact resolution (640x 1280) there is lots of unused frames there.
Tileset:
Im planning to fill free frames in later PRs.