-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable paying up front in Production queue #21295
Conversation
ae60f50
to
2cbafc4
Compare
related #7055 |
Generals Alpha already has a similar logic to make the actor paid fully when queued, as that's how it worked in Generals (the boolean is called InstantCashDrain there). Tho, it does not disable the icons, which was also not the case in original D2k for Starport. Icons only blacked out if you didn't have any of the units in stock or you've passed the total/per unit queue already. So i don't think that's something we want here, and even if we would want to keep the logic, it should be tried to a seperate value imo, so it can be enabled/disabled independent from MoneyUpFront. |
2cbafc4
to
5aa05fd
Compare
5aa05fd
to
6e93a94
Compare
|
6e93a94
to
9de4885
Compare
There was concerts about how this PR lead forward to d2k starport, so lets me adress it here:
But I still think this PR hold by its own, because:
|
9de4885
to
f2e9513
Compare
f2e9513
to
6ed4e30
Compare
6ed4e30
to
5a1cce4
Compare
Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is weird that you can't even go to a tab if you don't have enough money.
820fdb3
to
7734d98
Compare
Fixed, but not sure if this is the best solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that looks about correct, left some comments.
e935701
to
31f6058
Compare
Fix tab availability on low money Co-Authored-By: Gustas <37534529+PunkPun@users.noreply.github.com>
31f6058
to
a711bd6
Compare
This PR implements some features thats D2k Starport will need.
In OG D2k Starport tab behaves like this;
This PR implements first two steps. It adds MoneyUpFront options into the ProductionQueue.
Example how its work on ClassicProductionQueues:
2024-01-10.16-54-16.mp4
Example how its work with my LUA Starport implementation:
2024-01-10.16-53-15.mp4
Im not sure if this is the right way to code this, so feal free for suggestions.