-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D2k Starport #21424
base: bleed
Are you sure you want to change the base?
D2k Starport #21424
Conversation
Is this the thing where there is a limited number of each unit type? IMO its fine to leave this and dynamic prices to a followup provided the rest of the mechanics are working correctly.
Does queueing even make sense here? |
yes, I thing best solution would be to to create Stock trait where properties as max stock size, replenishment rate etc will sit and StockManager which will handle logic like which stock should be pick up and why. But I prefer this to be done separately as its independent thing.
in context of d2k no :D . Maybe some modder would like to have also building/loading time for his delivery service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like quite a large PR, I didn't review everything yet
Please add punctuation to all trait property descriptions
0178710
to
39d60c5
Compare
updated according to your suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round of reviews.
Though I still haven't tested the PayUpFront
and BlockedIfInsolvent
additions to ProductionQueue
trait. Likewise the "fix" for refunding cash as resources instead of cash.
- fix resources to cash exploit - add option to block item if player doesn't have enough money.
- OG fly path and Frigate behaviour - BulkProductionQueue - ProductionStarport trait - OG palette widget behavior for Bulk queue - Purchase button for each BulkProduction - Delivery timer for each BulkProduction
39d60c5
to
0930499
Compare
done. Also used |
Successor of #21295 and #21423
related #7055
What this PR do:
What isn't part of this PR:
Know issues:
o Render ordered number in right corner instead of left.
o Disable queue number for BulkproductionQueue
IMO units you dont have money for should be disabled. Right now they are enable because in OG icons was disabled only if they was out of stock.
2024-05-17.15-20-05.mp4