Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2k Starport #21424

Open
wants to merge 3 commits into
base: bleed
Choose a base branch
from
Open

D2k Starport #21424

wants to merge 3 commits into from

Conversation

Porenutak
Copy link
Contributor

Successor of #21295 and #21423
related #7055

What this PR do:

  • OG fly path and behaviour for Frigate
  • Paying up front for Starport units
  • BulkProductionQueue allowing to order multiple units
  • ProductionStarport trait for delivering multiple units
  • OG palette widget behavior for BulkproductionQueue
  • OG refund behaviour (Fix resource to cash exploit in ProductionQueue)
  • UI with Purchase button and delivery timer

What isn't part of this PR:

  • Stockpiles
  • dynamic prices

Know issues:

  • Queue numbers and ordered numbers overlap between ticks. Possible solution:
    o Render ordered number in right corner instead of left.
    o Disable queue number for BulkproductionQueue

IMO units you dont have money for should be disabled. Right now they are enable because in OG icons was disabled only if they was out of stock.

2024-05-17.15-20-05.mp4

@pchote
Copy link
Member

pchote commented May 17, 2024

Stockpiles

Is this the thing where there is a limited number of each unit type? IMO its fine to leave this and dynamic prices to a followup provided the rest of the mechanics are working correctly.

Disable queue number for BulkproductionQueue

Does queueing even make sense here?

@Porenutak
Copy link
Contributor Author

Porenutak commented May 17, 2024

Is this the thing where there is a limited number of each unit type?

yes, I thing best solution would be to to create Stock trait where properties as max stock size, replenishment rate etc will sit and StockManager which will handle logic like which stock should be pick up and why. But I prefer this to be done separately as its independent thing.

Does queueing even make sense here?

in context of d2k no :D . Maybe some modder would like to have also building/loading time for his delivery service.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like quite a large PR, I didn't review everything yet

Please add punctuation to all trait property descriptions

OpenRA.Game/Actor.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/DeliverBulkOrder.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/DeliverBulkOrder.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/DeliverBulkOrder.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Player/BulkProductionQueue.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Player/BulkProductionQueue.cs Outdated Show resolved Hide resolved
OpenRA.Mods.D2k/Widgets/Logic/PurchaseWidgetLogic.cs Outdated Show resolved Hide resolved
mods/d2k/uibits/chrome.png Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Widgets/ProductionPaletteWidget.cs Outdated Show resolved Hide resolved
@Porenutak Porenutak force-pushed the Purchase-button branch 4 times, most recently from 0178710 to 39d60c5 Compare May 20, 2024 13:23
@Porenutak
Copy link
Contributor Author

updated according to your suggestions

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of reviews.

Though I still haven't tested the PayUpFront and BlockedIfInsolvent additions to ProductionQueue trait. Likewise the "fix" for refunding cash as resources instead of cash.

OpenRA.Mods.Common/Traits/Player/BulkProductionQueue.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Player/BulkProductionQueue.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/DeliverBulkOrder.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/DeliverBulkOrder.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/DeliverBulkOrder.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/ProductionStarport.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/ProductionStarport.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/ProductionStarport.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Cargo.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Player/BulkProductionQueue.cs Outdated Show resolved Hide resolved
- fix resources to cash exploit
- add option to block item if player doesn't have enough money.
- OG fly path and Frigate behaviour
- BulkProductionQueue
- ProductionStarport trait
- OG palette widget behavior for Bulk queue
- Purchase button for each BulkProduction
- Delivery timer for each BulkProduction
@Porenutak
Copy link
Contributor Author

done. Also used BlockedIfInsolvent as it makes more sense to block icons that cannot be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants