Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide names and pools when creating MiniYaml. #21299

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Provide names and pools when creating MiniYaml. #21299

merged 1 commit into from
Jan 21, 2024

Commits on Jan 13, 2024

  1. Provide names and pools when creating MiniYaml. 

    - Rename the filename parameter to name and make it mandatory. Review all callers and ensure a useful string is provided as input, to ensure sufficient context is included for logging and debugging. This can be a filename, url, or any arbitrary text so include whatever context seems reasonable.
- When several MiniYamls are created that have similar content, provide a shared string pool. This allows strings that are common between all the yaml to be shared, reducing long term memory usage. We also change the pool from a dictionary to a set. Originally a Dictionary had to be used so we could call TryGetValue to get a reference to the pooled string. Now that more recent versions of dotnet provide a TryGetValue on HashSet, we can use a set directly without the memory wasted by having to store both keys and values in a dictionary.
    @RoosterDragon
    RoosterDragon committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    5cb0b3e View commit details
    Browse the repository at this point in the history