Render Cloak Traits #21329
Open
Render Cloak Traits #21329
+474
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
reviewed
Feb 5, 2024
There was a problem hiding this comment.
A future issue with cloak is cloak transition effects #12195. The unit needs to remain visible during transitions otherwise the opponent won't see the effects. I recon we should bake this in into the architecture from the very start
this was the original transition commit https://github.com/OpenRA/OpenRA/commit//f44819c92ac67b8b9db0ba67e1cc7bde97a57e41
Another issue with transitions is deciding when to play the sound. For base mods it should be at the start of transition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plumbing for separating cloak rendering from the
Cloaktrait itself and includes cloak rendering traits as well as upgrade rule updates. It is designed to address the architectural mentioned in the discussion for #21294. The second commit ports dnqbob's additions in #21294 to a new trait calledRenderCloakShiftingAlpha. As such, this PR should supersede #21294.