Fix force rally point not setting building as primary#21348
Merged
abcdefg30 merged 1 commit intoOpenRA:bleedfrom Feb 23, 2024
Merged
Fix force rally point not setting building as primary#21348abcdefg30 merged 1 commit intoOpenRA:bleedfrom
abcdefg30 merged 1 commit intoOpenRA:bleedfrom
Conversation
atlimit8
approved these changes
Feb 18, 2024
Member
atlimit8
left a comment
atlimit8
left a comment
There was a problem hiding this comment.
It not only works, the idea of path finding for the buildings themselves does not make sense. The use of ClosestToWithPathTo(this IEnumerable<Actor> actors, World world, WPos targetPosition) was looking for a path that the production facility can take. The intention was probably for validating the location. However, That would require being able to check against the types of actors that can be produced, assuming that a mod does not have some custom use for the rally point such as auto-spawning actors.
abcdefg30
approved these changes
Feb 23, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21312
Regression from #20227
buildings can't move so the search failed