Spawn aircraft occupying land or at cruise altitude #21366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldgg2
reviewed
Mar 11, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
PunkPun
changed the title
PunkPun
changed the title
abcdefg30
reviewed
Apr 10, 2024
|
This PR broke Autocarryall trait for carryalls spawned via map and scripts. If you build carryall in building it works fine, but for spawned units no. Otherwise looks ok. |
|
Weird that Carryalls on shellmap worked just fine. The issue was that Carryall checks wether current activity was FlyIdle and due to the way they are queued it was AssociateWithAirfieldActivity instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #21076
Fixes #21305
Fixes #21339
Fixes #21384
Aircraft spawned by map and spawned by starting unit now have new behaviour. They always either occupy and an airpad, are occupying ground or are spawned at cruise altitude
or testing see cnc - TwistOfFate. Helicopters are parked on airfields, or download d2k testcase from to see that carryalls are spawned airborne #21305