Skip to content

Spawn aircraft occupying land or at cruise altitude#21366

Merged
Mailaender merged 2 commits into
OpenRA:bleedfrom
PunkPun:fix-start
Jul 20, 2024
Merged

Spawn aircraft occupying land or at cruise altitude#21366
Mailaender merged 2 commits into
OpenRA:bleedfrom
PunkPun:fix-start

Conversation

@PunkPun

@PunkPun PunkPun commented Mar 11, 2024

Copy link
Copy Markdown
Member

Followup on #21076

Fixes #21305
Fixes #21339
Fixes #21384

Aircraft spawned by map and spawned by starting unit now have new behaviour. They always either occupy and an airpad, are occupying ground or are spawned at cruise altitude

or testing see cnc - TwistOfFate. Helicopters are parked on airfields, or download d2k testcase from to see that carryalls are spawned airborne #21305

@PunkPun PunkPun added this to the Next Release milestone Mar 11, 2024
Comment thread OpenRA.Mods.Common/Traits/World/SpawnStartingUnits.cs Outdated
@Porenutak

This comment was marked as resolved.

@PunkPun

This comment was marked as resolved.

@michaeldgg2

This comment was marked as resolved.

@PunkPun

This comment was marked as resolved.

@PunkPun PunkPun changed the title Spawn starting aircraft at cruise altitude Spawn aircraft landed and occupying land or at cruise altitude Mar 28, 2024
@PunkPun PunkPun changed the title Spawn aircraft landed and occupying land or at cruise altitude Spawn aircraft occupying land or at cruise altitude Mar 28, 2024
Comment thread OpenRA.Mods.Common/Traits/World/SpawnMapActors.cs Outdated
@Porenutak

Porenutak commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

This PR broke Autocarryall trait for carryalls spawned via map and scripts. If you build carryall in building it works fine, but for spawned units no.
testmap.zip

Otherwise looks ok.

@PunkPun

PunkPun commented Apr 11, 2024

Copy link
Copy Markdown
Member Author

Weird that Carryalls on shellmap worked just fine. The issue was that Carryall checks wether current activity was FlyIdle and due to the way they are queued it was AssociateWithAirfieldActivity instead

@PunkPun PunkPun force-pushed the fix-start branch 2 times, most recently from fb91be4 to 1e98753 Compare April 11, 2024 13:46
@Mailaender Mailaender merged commit 7b01204 into OpenRA:bleed Jul 20, 2024
@Mailaender

Copy link
Copy Markdown
Member

Changelog

@PunkPun PunkPun deleted the fix-start branch July 21, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants