Fix crashing when transports are loaded via lua and related regressions #21076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
force-pushed
the
fix-transports
branch
from
73c0c31
to
37535e7
Compare
PunkPun
changed the title
PunkPun
force-pushed
the
fix-transports
branch
from
13780c1
to
ea77012
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
PunkPun
force-pushed
the
fix-transports
branch
from
ea77012
to
f8c0fd3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
pchote
previously approved these changes
Oct 29, 2023
PunkPun
force-pushed
the
fix-transports
branch
from
f8c0fd3
to
81875b9
Compare
|
Added a commit that reinforces carryalls on d2k shellmap instead of spawning them |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
PunkPun
force-pushed
the
fix-transports
branch
from
81875b9
to
6781ae7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
PunkPun
force-pushed
the
fix-transports
branch
2 times, most recently
from
fe39526
to
4a9a972
Compare
PunkPun
force-pushed
the
fix-transports
branch
2 times, most recently
from
ae84ec5
to
ba3c9a2
Compare
penev92
previously approved these changes
Nov 14, 2023
PunkPun
force-pushed
the
fix-transports
branch
2 times, most recently
from
c1274e5
to
56bbb7d
Compare
This was referenced Nov 27, 2023
pchote
previously approved these changes
Dec 3, 2023
|
Needs a rebase, then go ahead and merge. |
And allow to interrupt actor creation child activities
PunkPun
force-pushed
the
fix-transports
branch
from
56bbb7d
to
dd4cc4f
Compare
|
Rebased |
pchote
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21078
Fixes #21119
Fixes #21156
Fixes #21229
Fixes #21213
Supersedes #21208
Regression from #20825
Crash:
This PR entails that aircraft will no longer automatically take-off when placed on the map, restoring the legacy behaviour
An alternative solution would be to never call GetCreationActivity if actor is not to be added to world. Or perhaps instead pass that info down to the GetCreationActivity activity. It would make crashes possibly easier to debug.