Trim empty space around edges of Shp(TD) frames#21368
Conversation
|
The number of sheets generated by --dump-sequence-sheets go down by TD 2 -> 1 |
RoosterDragon
left a comment
There was a problem hiding this comment.
Could we get a list of items where the selection bounds have changed? Could be useful for any follow-up that wants to tidy those up.
|
#15194 was implemented as a much more robust solution to batch breakage - meaning that packing everything into one texture was no longer needed. Do we have any perf numbers to indicate that trimming is worthwhile under this newer system? |
|
as the sprite sheets are uncompressed, the empty space is eating up quite a bit of RAM. So removing empty sheets definitely way more impact than all the micro-optimisations we do |
|
Only 16MB at the default sheet size, so i'm unconvinced that its worth the potential disruption (and that has definitely been true for most of those other optimisations...) |
|
Yes the focus now would just be on the memory and not the batching gains. <100 lines to reduce our memory footprint by 5% is a nice win in my opinion. There was some pain when it was added originally, but since we've already dealt with the pain of finding and fixing the regressions, we've already paid those costs. |
Co-Authored-By: Paul Chote <pchote@users.noreply.github.com>
Regression from OpenRA/OpenRA#21368 , i assume.


Revives #15148. It appears the original issues were fixed along the years. I suspect the addition of anti-aliasing had an effect on it.
#15184 (comment) is still present but we can't do anything about it. The 2nd option was chosen back then and we can choose it again. Auto bounds is correct much more often than its not anyhow.