Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim empty space around edges of Shp(TD) frames #21368

Open
wants to merge 1 commit into
base: bleed
Choose a base branch
from

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Mar 12, 2024

Revives #15148. It appears the original issues were fixed along the years. I suspect the addition of anti-aliasing had an effect on it.

#15184 (comment) is still present but we can't do anything about it. The 2nd option was chosen back then and we can choose it again. Auto bounds is correct much more often than its not anyhow.

@PunkPun
Copy link
Member Author

PunkPun commented Mar 12, 2024

The number of sheets generated by --dump-sequence-sheets go down by

TD 2 -> 1
RA 2 -> 1

Copy link
Member

@RoosterDragon RoosterDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a list of items where the selection bounds have changed? Could be useful for any follow-up that wants to tidy those up.

OpenRA.Mods.Cnc/SpriteLoaders/ShpTDLoader.cs Show resolved Hide resolved
@PunkPun
Copy link
Member Author

PunkPun commented Mar 12, 2024

This is the diff e4be18d

Generated with 69fc1e1

Co-Authored-By: Paul Chote <pchote@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants