added sorting of names to earnings graph#21410
Merged
PunkPun merged 1 commit intoOpenRA:bleedfrom Apr 30, 2024
Merged
Conversation
RoosterDragon
approved these changes
Apr 27, 2024
ThomasChr
approved these changes
Apr 28, 2024
Contributor
ThomasChr
left a comment
ThomasChr
left a comment
There was a problem hiding this comment.
tested. Nice idea!
LGTM
PunkPun
approved these changes
Apr 30, 2024
Member
PunkPun
left a comment
PunkPun
left a comment
There was a problem hiding this comment.
This is not entirely correct as if a player is dead a point with 0 value isn't added, but it's an improvement
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used make check, make test, and make tests, all of which passed. I then did make all and ran the game to see if the feature worked and it appears to work exactly as intended.