Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sorting of names to earnings graph #21410

Merged
merged 1 commit into from Apr 30, 2024

Conversation

ryanjschneebaum
Copy link

I used make check, make test, and make tests, all of which passed. I then did make all and ran the game to see if the feature worked and it appears to work exactly as intended.

Copy link
Contributor

@ThomasChr ThomasChr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. Nice idea!
LGTM

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not entirely correct as if a player is dead a point with 0 value isn't added, but it's an improvement

@PunkPun PunkPun merged commit affc988 into OpenRA:bleed Apr 30, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Apr 30, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants