Auto map downloading implementation in sync mode #2580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested joining a server with an unknown map and it worked quite well. It is okay to have no progress shown with a GUI, because this way it will also work with dedicated servers and the download is too fast for broadband to get noticed anyway. However the AllowDownload should be exposed to the settings GUI with some explanations on how this works and where to upload maps (this is not obvious). Maybe even don't hard-code http://content.open-ra.org/ but make it a yaml setting, too (compare MasterServer). |
|
This will fix #2032. |
|
👍 to having the URL exposed in config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.