Asynchronous loading of map previews in the map chooser dialog #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens if the filter is changed while the list is still populating? |
|
(Otherwise looks good, just concerned about races.) |
|
Tested, works for all mods. Supersedes pull request #5. |
|
Fixed the filter. (It didn't crash, however if you changed it, it loaded the maps the "old" way while the async one was still loading the maps in the other thread.) |
|
Looks good to me. |
|
Merged, thanks @Carko. |
|
It seems to make the order of the maps all weird on subsequent openings of the map chooser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added async loading of map previews in the map chooses dialog based on the idea from Pull request 5.
The problem with it was that while the items were added asynchronously to the list, the actual map loading was done in the GUI thread since the map was first loaded and added to the cache in the Draw() override of the MapPreviewWidget.
I have added a method that forces loading the map preview into the cache and that can be called from another thread.