Renderer refactoring - Renderables

[pchote]

This streamlines the creation and drawing of Renderables, dropping a lot of accumlated cruft and adding support for alternative renderable types in the future (voxels, laser zaps, range circles).

Renderables have been generalized from additional Sprite state to an interface describing "something that can draw itself", positioned using world coordinates.

I've tested that the common cases display properly, but I there may be edge cases i've missed - resulting in offset sprites or incorrect draw orders.

[chrisforbes]

This change makes the cache pretty upset :(

[cjshmyr]

@chrisforbes : for the uninformed, explain?

On Wed, May 15, 2013 at 2:51 PM, Chris Forbes notifications@github.comwrote:

This change makes the cache pretty upset :(

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3286#issuecomment-17965372
.

[pchote]

@cjshmyr: He means that putting a pile of virtual function calls in the hot path of the renderer wasn't the smartest idea performance wise...
@chrisforbes: I've tweaked the patch to use an interface on structs instead.

[Mailaender]

The Red Alert Destroyer and Cruiser turrets are mis-aligned.

[Mailaender]

Red Alert Flak Truk turret is also mis-aligned.

[pchote]

Thanks for the report @Mailaender. Sounds like custom turret offsets are busted in general.

[pchote]

Updated to fix the turret offset issue.

[chrisforbes]

👍 but I'd like @cjshmyr to take a look as well.

[cjshmyr]

👍

[Mailaender]

One glitch remaining: turrets are rendered on top of the RA weapon factory while they are spawning inside.

[pchote]

Whoops, that was introduced by the turret offset fix. Fixed in f7aca32.

[Mailaender]

One minor rendering regression left: aircraft shadows are not drawn over regular buildings. They just vanish which looks slightly glitchy. Repair bay and heli pad work however.

[Mailaender]

Could you also please move the flak truk turret a little more towards the front again. It seems to be just few pixels, but I noticed the difference and the gap looks strange.

[pchote]

Fixed. The flak truck turret was mispositioned by only 1px when facing south.

[Mailaender]

The flak truk turret is rendered on top of the weapon factory and there are rendering glitches with boats, their turrets and naval production buildings also in regard to rendering order.

[pchote]

Fixed. These edge cases are a PITA, but I'd rather solve them now than later.

[Mailaender]

I noticed that those edge cases exist in RA2.exe as shadows of trees are not properly rendered upon walls etc. and I also get SHP overlay glitches in Tiberian Sun with explosions so it seems we are already better than the original in this regard. Good work. 👍