Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made husks targetable with force fire only #4941

Merged
merged 1 commit into from Apr 3, 2014

Conversation

Mailaender
Copy link
Member

This is a remake of #3955 which allows force fire to kill husks without making the AI go crazy or annoy players in the height of the battle.

@@ -199,6 +199,9 @@ bool CanTargetActor(Actor self, Target target, TargetModifiers modifiers, ref st
if (modifiers.HasModifier(TargetModifiers.ForceMove))
return false;

if (target.Actor.HasTrait<Husk>())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 for hardcoding a gameplay decision that other mods may not want into our low-level shared traits.

This probably wants to live as a flag on the ITargetable interface / implementations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it also fits good at bridges. Updated.

@pchote pchote added this to the Next playtest milestone Apr 2, 2014
@Mailaender
Copy link
Member Author

Renamed the internal functions and variables as @pchote suggested.

@@ -85,6 +85,11 @@ public bool IsValidFor(Actor targeter)
return true;
}

public bool RequiresForceFire()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a property to be consistent with the rest of Target.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean get { return targetable != null && targetable.RequiresForceFire; }?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@phrohdoh
Copy link
Member

phrohdoh commented Apr 2, 2014

I can't test this at the moment but if it all works and is nice internally: 👍

@pchote
Copy link
Member

pchote commented Apr 3, 2014

👍 after a couple of final consistency fixes:

  • ForceFireOnly -> RequiresForceFire
  • Include explicit = false in the *Info definitions.

@Mailaender
Copy link
Member Author

Updated.

@pchote
Copy link
Member

pchote commented Apr 3, 2014

Good job. It will be nice to finally put the husk-abuse exploits to rest.

One (unconsidered?) side effect is that nukes will now vaporize the units in their blast, instead of leaving husks.

pchote added a commit that referenced this pull request Apr 3, 2014
Made husks targetable with force fire only
@pchote pchote merged commit 94b2deb into OpenRA:bleed Apr 3, 2014
@Mailaender Mailaender deleted the kill-husks branch April 3, 2014 15:04
@Mailaender
Copy link
Member Author

I also noticed that shooting with lot's of rockets on a tank can also kill the husk afterwards. We can combat this with more HP (and higher Burns: damage) for the wrecks.

@phrohdoh
Copy link
Member

phrohdoh commented Apr 3, 2014

I don't think we should change HP due to a visual polish/husk-abuse-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants