Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GDI01 secondary objectives and mission descriptions #7052

Merged
merged 2 commits into from
Dec 24, 2014

Conversation

Mailaender
Copy link
Member

Split from #6880.

@pchote
Copy link
Member

pchote commented Dec 2, 2014

In #6880 @obrakmann expressed horror over introducing MarkIncompleteObjective and I commented that the problem is that the secondary objective has no real purpose in this mission. Expand the first outdated comment thread for more details.

@Mailaender
Copy link
Member Author

Updated. This makes use of Lua API improvements from #7081 and #6762 now.

@obrakmann
Copy link
Contributor

👍

@abcdefg30
Copy link
Member

Shouldn't the secondary objective be marked as failed if you lose your entire base?

@Mailaender
Copy link
Member Author

Yes. Do you mean that is broken here?

@abcdefg30
Copy link
Member

Yeah, somehow...
gdi01base

And you're able to complete the objective by building just 2 nukes, intentional?

@pchote
Copy link
Member

pchote commented Dec 13, 2014

Shouldn't the secondary objective be marked as failed if you lose your entire base?

If the objective has a purpose (like giving reinforcements), then I think no - the objective has already been completed and you have been rewarded for it.

@Mailaender
Copy link
Member Author

@abcdefg30 All your men need to die for that to fail completely. My first attempt was to revert that objective back to incomplete, but that was rejected.

@Mailaender
Copy link
Member Author

Updated. You now can't sell your base (as we still need it for GDI02) and I made an attempt to fix the gunboat stopping when acquiring a new target. A regression introduced by #7067.

@obrakmann
Copy link
Contributor

The boat now moves, but doesn't target anything automatically anymore.

@Mailaender
Copy link
Member Author

Which is weird. I don't understand why.

@Mailaender
Copy link
Member Author

Rebased and removed my failt attempt to fix #7128 now that #7169 has been merged.

nodObjective = enemy.AddPrimaryObjective("Destroy all GDI troops")
gdiObjective1 = player.AddPrimaryObjective("Eliminate all Nod forces in the area")
gdiObjective2 = player.AddSecondaryObjective("Establish a beachhead")
Media.PlayMovieFullscreen("landing.vqa", function()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this reverting the recent FMV changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am an idiot. Resolved the merge conflict towards the wrong way and did not even notice that this plays the movies twice. Fixed.

@abcdefg30
Copy link
Member

👍

1 similar comment
@obrakmann
Copy link
Contributor

👍

obrakmann added a commit that referenced this pull request Dec 24, 2014
Fixed GDI01 secondary objectives and mission descriptions
@obrakmann obrakmann merged commit 659d677 into OpenRA:bleed Dec 24, 2014
@Mailaender Mailaender deleted the gdi01-polishing branch December 24, 2014 13:31
@obrakmann
Copy link
Contributor

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants